Skip to content

Boost near_derive #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CohenCyril wants to merge 6 commits into from
Closed

Boost near_derive #1491

CohenCyril wants to merge 6 commits into from

Conversation

@CohenCyril
Copy link
Member

@CohenCyril CohenCyril commented Feb 20, 2025 •
edited
Loading

Motivation for change

simplify and generalize #1477

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@CohenCyril CohenCyril changed the title ##### Motivation for this change Boost near_derive Feb 20, 2025
@CohenCyril CohenCyril force-pushed the derive_20250214 branch 2 times, most recently from b119a06 to c9d7650 Compare February 20, 2025 09:51
@CohenCyril
Copy link
Member Author

CohenCyril commented Feb 20, 2025

@affeldt-aist I will have to readapt to the changes made after I started editing, but that's the idea...
Will doing the refactoring I coined a few other generalizations to make in the library, and that I will strive to push in the comming weeks (hence I'm not solving issue #1489 )

@CohenCyril
Copy link
Member Author

CohenCyril commented Feb 20, 2025

I might have s***d up the merge

@t6s
Copy link
Member

t6s commented Feb 22, 2025

near0Z will be useful in many similar cases

@affeldt-aist affeldt-aist added this to the 1.10.0 milestone Apr 10, 2025
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Apr 10, 2025
CohenCyril and others added 2 commits April 10, 2025 23:19
@CohenCyril @affeldt-aist
Boost near_derive
3eeff58 
Simpler proof of a stronger version of near_derive
@affeldt-aist
changelog
5fa7a69
CohenCyril
CohenCyril commented Apr 11, 2025
View reviewed changes
@affeldt-aist affeldt-aist mentioned this pull request Apr 15, 2025
Merged
1 task
@affeldt-aist
Copy link
Member

affeldt-aist commented Apr 15, 2025

Work has been moved to PR #1574

@affeldt-aist affeldt-aist added the wontfix/merge 🚫 We wont fix this issue/merge this PR, we will close it soon label Apr 15, 2025
@affeldt-aist affeldt-aist marked this pull request as draft April 15, 2025 07:10
@CohenCyril CohenCyril closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@t6s t6s t6s approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library wontfix/merge 🚫 We wont fix this issue/merge this PR, we will close it soon

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@CohenCyril @t6s @affeldt-aist